Fix GH-19044: Protected properties are not scoped according to their prototype #19046
Conversation
bwoebi
force-pushed
the
fix-19044
branch
5 times, most recently
from
e8099c0 to
e1008f8
Compare
|
@iluuu1994 May you please re-review now? :-) |
I think we might opt into relaxing this eventually, but I would not allow more than actually needed at least for PHP 8.4. We can always revisit it, but I don't think we should do that now. |
|
@iluuu1994 Alright, let's just use prototype for everything. |
| @@ -0,0 +1,26 @@ | |||
| --TEST-- | |||
| GH-19044: Protected properties must be scoped according to their prototype (hooks variation) | |||
There was a problem hiding this comment.
Nit: We have gh19044.phpt and gh19044-1.phpt (along with other gh19044.phpt's), which is a bit confusing.
There was a problem hiding this comment.
So you'd rather have attached a number to them all? I thought first one without number and the extras get one.
There was a problem hiding this comment.
Yes, or bump all the other ones by one so we don't have one with without prefix and one with -1. Usually we'll have:
- gh123.phpt
- gh123-2.phpt
Or:
- gh123-1.phpt
- gh123-2.phpt
I prefer the latter, but either works.
This should properly cover all cases, especially also around set hooks which get added later on with protected(set) visibility.
Fixes #19044.